PDA

View Full Version : just busy with sponsored links...


Olaf Lederer
11-30-2006, 11:01 PM
hello,

I noticed that there is no email send after the payment is done:


function getAdmins()
{
$sql = "SELECT * ";
$sql .= "FROM `{$this->mPrefix}admins` ";
$sql .= "WHERE `status` = 'active'";

return $this->mDb->getRow($sql);
}


must be


function getAdmins()
{
$sql = "SELECT * ";
$sql .= "FROM `{$this->mPrefix}admins` ";
$sql .= "WHERE `status` = 'active'";

return $this->mDb->getAll($sql);
}


further there is bug inside the file "purchase-complete.php"

the method
$gDirDb->setPlan($id_link, $id_plan, $tid);

is called already via the paypal plugin

further it makes no sense to activate the link after the payment is done, what if the link is from an illegal website?

I removed this code (and added a simple return)

$sql = "UPDATE `{$this->mPrefix}links` ";
$sql .= "SET `status` = 'active' ";
$sql .= "WHERE `id` = '{$aLink}'";

return $this->mDb->query($sql);

Sai_dallas
12-01-2006, 04:11 AM
Any comment from Dev or Support team on this?

Thanks

Michael Hill
12-01-2006, 05:15 AM
Hi, Olaf!

Function 'getAdmins()' in base files of both 1.2 and 2.0 versions contains getAll() function. Probably, you didn't use any patch for 1.2 or 2.0?

Olaf Lederer
12-01-2006, 05:37 AM
Hi, Olaf!

Function 'getAdmins()' in base files of both 1.2 and 2.0 versions contains getAll() function. Probably, you didn't use any patch for 1.2 or 2.0?

will say you fixed that for version 2.0.01?

what about the other comments?

Olaf Lederer
12-01-2006, 05:42 AM
Hi, Olaf!

Function 'getAdmins()' in base files of both 1.2 and 2.0 versions contains getAll() function. Probably, you didn't use any patch for 1.2 or 2.0?

just downloaded the latest version, this is what I get:
function getAdmins()
{
$sql = "SELECT * ";
$sql .= "FROM `{$this->mPrefix}admins` ";
$sql .= "WHERE `status` = 'active'";

return $this->mDb->getRow($sql);
}