PDA

View Full Version : Bug on submitting irc links


imagis
05-13-2007, 01:39 PM
Hello,

When submitting links as: irc://server.tld/channel is automatically added http:// at beginning of link

Sergey Ten
05-14-2007, 06:02 AM
Hello imagis,

If you want to remove "http://" from all links please following directives:

[ Open your suggest-link.php ]
[ Find code ]


if(!empty($_POST['url']))
{
$_POST['url'] = trim($_POST['url']);
$link['url'] = (0!==strpos($_POST['url'],"http://")) ? "http://".$_POST['url'] : $_POST['url'];
$_POST['url'] = $link['url'] = strip_tags($link['url']);
}


[ Replace with ]



if(!empty($_POST['url']))
{
$_POST['url'] = trim($_POST['url']);
$_POST['url'] = $link['url'] = strip_tags($link['url']);
}


[ Save change ]

imagis
05-14-2007, 10:39 AM
Thanks.

I am actually suggesting to be analyzed this as a bug, so in case of URL's as:

irc://
ftp://

to not be added http:// before them

Sergey Ten
05-15-2007, 06:49 AM
Hello imagis,

[ Find code ]


$link['url'] = (0!==strpos($_POST['url'],"http://")) ? "http://".$_POST['url'] : $_POST['url'];


[ Replace with ]


if((0 !== strpos($_POST['url'],"irc://")) && (0 !== strpos($_POST['url'],"ftp://"))
{
$link['url'] = (0 !== strpos($_POST['url'],"http://")) ? "http://".$_POST['url'] : $_POST['url'];
}
else
{
$link['url'] = $_POST['url'];
}


[ Save change ]